docs(subpath): revisited#394
Merged
pombredanne merged 1 commit intopackage-url:masterfrom Feb 19, 2025
Merged
Conversation
jkowalleck
force-pushed
the
package-url/spec/subpath-revisit
branch
from
ca19551 to
84244c6
Compare
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
package-url/spec/subpath-revisit
branch
from
84244c6 to
84a6995
Compare
jkowalleck
added
PURL core specification
jkowalleck
commented
Feb 13, 2025
| - Discard any empty string segment from that split | ||
| - Discard any '.' or '..' segment from that split | ||
| - Percent-decode each segment | ||
| - Discard any '.' or '..' segment from that split |
Member
Author
There was a problem hiding this comment.
percent decode first, then discard ../..
see the tests in accordance #368
johnmhoran
approved these changes
Feb 19, 2025
Member
johnmhoran
left a comment
johnmhoran
left a comment
There was a problem hiding this comment.
@jkowalleck Sorry for the delay -- looks good to me -- good catch! 👍
mprpic
approved these changes
Feb 19, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as of #379, the subpath part was revisited